signer/core/apitypes: fix issue in complex typed data signing #24220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
changed the title
|
Thanks, let's do it |
|
@fjl rebased, can you please 👍 ? |
fjl
approved these changes
Feb 8, 2022
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Feb 11, 2022
Co-authored-by: specerxi <xhxpecer@gmail.com>
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
Co-authored-by: specerxi <xhxpecer@gmail.com>
and00999
pushed a commit
to and00999/go-ethereum
that referenced
this pull request
Jul 7, 2022
Co-authored-by: specerxi <xhxpecer@gmail.com>
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #24102.
Looks good to me (I'm not the author)