Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trie: readonly interface for trie iterator's resolver #24221

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

darioush
Copy link
Contributor

Since resolver only uses methods from ethdb.KeyValueReader, this smaller interface can be used instead.

Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed resolver only calls .Get in resolveHash and by definition should only be used for reading.

Mersi Darioush

@s1na s1na changed the title trie.iterator.AddResolver: KeyValueStore -> KeyValueReader trie: readonly interface for trie iterator's resolver Jan 11, 2022
@karalabe karalabe added this to the 1.10.16 milestone Jan 11, 2022
@karalabe karalabe merged commit 2c58e6b into ethereum:master Jan 11, 2022
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Jan 12, 2022
JacekGlen pushed a commit to JacekGlen/go-ethereum that referenced this pull request May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants