signer/core: support chainId in GnosisSafeTx #24231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmv08
changed the title
|
Please revert the change on |
mmv08
force-pushed
the
feature/support-chainId-for-GnosisSafeTx
branch
from
e0c9d00
to
6e5286d
Compare
|
@holiman done |
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Jan 18, 2022
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After EIP-1344 - ChainID opcode was introduced, starting from 1.3.0 Gnosis Safe contracts added
chainIdto the EIP-712 domain for transactions - changelogThe
GnosisSafeTxstruct didn't support thechainIdproperty and couldn't be used with newer versions of the Safe contracts.This PR adds support for
chainIdinGnosisSafeTx, making it possible to use to transact with Safe Contracts version 1.3.0Thanks to @rmeissner for the help with the PR