Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/geth: make test pass on a pi4 by using lightkdf #24314

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

ligi
Copy link
Member

@ligi ligi commented Jan 30, 2022

before this change this test was failing reproducibly with:

--- FAIL: TestAccountImport (0.00s)
    --- FAIL: TestAccountImport/correct_account (5.08s)
        test_cmd.go:262: (stderr:4) INFO [01-30|04:50:50.619] Maximum peer count                       ETH=50 LES=0 total=50
        test_cmd.go:262: (stderr:4) INFO [01-30|04:50:50.619] Smartcard socket not found, disabling    err="stat /run/pcscd/pcscd.comm: no such file or directory"
        test_cmd.go:262: (stderr:4) WARN [01-30|04:50:50.622] Lowering memory allowance on 32bit arch  available=3838 addressable=2048
        test_cmd.go:262: (stderr:4) WARN [01-30|04:50:50.622] Sanitizing cache to Go's GC limits       provided=1024 updated=682
        test_cmd.go:262: (stderr:4) INFO [01-30|04:50:50.623] Set global gas cap                       cap=50,000,000
        test_cmd.go:242: killing the child process (timeout)
        test_cmd.go:116: not enough output, got until ◊:
            ---------------- (stdout text)
            
            ---------------- (expected text)
            ◊Address: {fcad0b19bb29d4674531d6f115237e16afce377c}

after this change this tests passes on a pi4 and it should also not harm the test to do lightkdf here

@holiman
Copy link
Contributor

holiman commented Jan 30, 2022 via email

@holiman holiman added this to the 1.10.16 milestone Jan 31, 2022
@holiman holiman merged commit 0c1bd22 into ethereum:master Jan 31, 2022
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Feb 1, 2022
JacekGlen pushed a commit to JacekGlen/go-ethereum that referenced this pull request May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants