ethclient: make CallContract also accept block hash #24354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiqiangxu
requested review from
gballet and
MariusVanDerWijden
as code owners
zhiqiangxu
changed the title
|
This change is not possible because it is an API change. If this functionality is required for your application, we need to create a new API method for it. |
I created another PR to create a new API method : I found this method is required when trying to seamlessly and incrementally synchronize contract state to local database. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client.CallContractshould be aligned withPublicBlockChainAPI.Callso that the user can choose to call contract at specific height or block hash.Constants like
EarliestBlockNumberorLatestBlockNumbercan still be used with minimal change .