p2p: reduce the scope of dialPubkey #24385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiqiangxu
changed the title
fjl
approved these changes
Feb 14, 2022
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Feb 14, 2022
dialPubkey isn't used anywhere else after dialDest.Load, so it should be safe to restrict its scope to the if clause.
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
dialPubkey isn't used anywhere else after dialDest.Load, so it should be safe to restrict its scope to the if clause.
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Sep 30, 2022
dialPubkey isn't used anywhere else after dialDest.Load, so it should be safe to restrict its scope to the if clause.
nibty
pushed a commit
to FairCrypto/go-ethereum
that referenced
this pull request
Apr 10, 2024
dialPubkey isn't used anywhere else after dialDest.Load, so it should be safe to restrict its scope to the if clause.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dialPubkeyisn't used anywhere else afterdialDest.Load, so it should be safe to restrict its scope to theif clause.