core/rawdb: add HasCode, HasTrieNode and use them where possible #24454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
requested review from
karalabe,
holiman and
rjl493456442
as code owners
| return data | ||
| } | ||
|
|
||
| // HasCode checks if the contract code corresponding to the | ||
| // provided code hash is present in the db. | ||
| func HasCode(db ethdb.KeyValueReader, hash common.Hash) bool { |
There was a problem hiding this comment.
Can you move this function after ReadCodeWithPrefix?
We have this order for db APIs read, has, write, delete. Would be nice to keep this order.
There was a problem hiding this comment.
done! also reordered other functions.
rjl493456442
approved these changes
Feb 23, 2022
|
I believe the failing test is unrelated to those changes. Run the failing test ( |
fjl
changed the title
fjl
changed the title
|
Damn, typo in commit message. |
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Mar 9, 2022
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Sep 30, 2022
cp-wjhan
pushed a commit
to cp-yoonjin/go-wemix
that referenced
this pull request
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does following:
1- Adds
HasCodeand replace it withReadCodewherever possible.2- Changes
ReadTrieNodefunctions withHasTrieNode, in main and pruner packages.The reference commit:
893502e