core: store genesis allocation and recommit them if necessary #24460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
reviewed
Feb 23, 2022
core/blockchain.go
Outdated
| // block stored in the chain if the historical chain pruning is enabled. | ||
| // In that case the logic needs to be improved here. | ||
| if newHeadBlock.NumberU64() == 0 { | ||
| if err := CommitGenesisState(bc.db, bc.genesisBlock.Hash()); err != nil { |
There was a problem hiding this comment.
Won't this error out in backwards-incompatible way? I mean, if the genesis state already exists, but we haven't stored the genesis json?
There was a problem hiding this comment.
Right... thanks for catching it. Let me think how to solve it.
There was a problem hiding this comment.
I added two additional checks for it.
- if the genesis state is still available, do nothing here
- if the genesis state is gone and relevant genesis allocation can be recovered(mainnet, testnets), recover it
However, if it's a private network and the allocation is not persisted, and the genesis state is gone, then we can do nothing here.
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Mar 23, 2022
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
…um#24460) * core: store genesis allocation and recommit them if necessary * core: recover predefined genesis allocation if possible
cp-wjhan
pushed a commit
to cp-yoonjin/go-wemix
that referenced
this pull request
Nov 16, 2022
…um#24460) * core: store genesis allocation and recommit them if necessary * core: recover predefined genesis allocation if possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative of #24450.
It will store the genesis allocation information into the disk,
and whenever we want to rewind the state to genesis, the
genesis allocation can be loaded and generate the genesis
states.