eth/catalyst: only apply block if we actually have the state #24598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
reviewed
Mar 29, 2022
karalabe
reviewed
Mar 29, 2022
holiman
reviewed
Mar 29, 2022
cmd/geth/dbcmd.go
Outdated
Comment on lines
750
to
752
| if b := rawdb.ReadSkeletonSyncStatus(db); b != nil { | ||
| data = append(data, []string{"SkeletonSyncStatus", fmt.Sprintf("%s", b)}) | ||
| } |
There was a problem hiding this comment.
cmd/geth/dbcmd.go:751:54: S1025: the argument's underlying type is a slice of bytes, should use a simple conversion instead of fmt.Sprintf (gosimple)
data = append(data, []string{"SkeletonSyncStatus", fmt.Sprintf("%s", b)})
^
holiman
reviewed
Mar 29, 2022
Co-authored-by: Martin Holst Swende <martin@swende.se>
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Apr 3, 2022
…m#24598) * eth/catalyst: only apply block if we actually have the state * add header to payload queue * Update cmd/geth/dbcmd.go Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Martin Holst Swende <martin@swende.se>
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
…m#24598) * eth/catalyst: only apply block if we actually have the state * add header to payload queue * Update cmd/geth/dbcmd.go Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Martin Holst Swende <martin@swende.se>
cp-wjhan
pushed a commit
to cp-yoonjin/go-wemix
that referenced
this pull request
Nov 16, 2022
…m#24598) * eth/catalyst: only apply block if we actually have the state * add header to payload queue * Update cmd/geth/dbcmd.go Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Martin Holst Swende <martin@swende.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the state for the parent block is available, otherwise we might incur bad block errors