Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/geth: change to non-fatal error message when legacy receipt storage is not implemented #24603

Merged
merged 3 commits into from
Mar 29, 2022
Merged

cmd/geth: change to non-fatal error message when legacy receipt storage is not implemented #24603

merged 3 commits into from
Mar 29, 2022

Conversation

jwasinger
Copy link
Contributor

fixes #24602

@jwasinger jwasinger requested a review from s1na March 29, 2022 01:08
rjl493456442
rjl493456442 reviewed Mar 29, 2022
View reviewed changes
cmd/geth/config.go Outdated Show resolved Hide resolved
@karalabe
Copy link
Member

I'm not entirely sure what the purpose of this PR is? Dev mode is just like all the other modes, it should not have db checks disabled. If someone has an old db, it should be treated just like an old db of mainnet, it needs to be upgraded somehow. Otherwise it won't be accessible any more.

Wasn't there a db command to update the legacy format to new?

@rjl493456442
Copy link
Member

ev mode is just like all the other modes, it should not have db checks disabled. If someone has an old db, it should be treated just like an old db of mainnet, it needs to be upgraded somehow. Otherwise it won't be accessible any more.

The reason is: for legacy receipt format checking, it will invoke some ancient store API, but memorydb doesn't implement it(dev mode), so an error is occurred.
I think we can drop the dev checking, but just degrade the log level to Error Level instead of Crit

holiman
holiman approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.10.17 milestone Mar 29, 2022
@jwasinger jwasinger changed the title Don't check for legacy receipts when --dev mode is enabled Degrade fatal error to log error message when legacy receipt storage is not implemented Mar 29, 2022
holiman
holiman approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still lgtm

@holiman holiman changed the title Degrade fatal error to log error message when legacy receipt storage is not implemented cmd/geth: change to non-fatal error message when legacy receipt storage is not implemented Mar 29, 2022
@holiman holiman merged commit b502b6a into ethereum:master Mar 29, 2022
@jwasinger jwasinger deleted the fix/legacy-receipt-check branch May 13, 2022 01:55
JacekGlen pushed a commit to JacekGlen/go-ethereum that referenced this pull request May 26, 2022
@jwasinger @rjl493456442 @JacekGlen
cmd/geth: change to non-fatal error message when legacy receipt stora…
c190165 
…ge is not implemented (ethereum#24603)

* cmd/geth: only check for presence of legacy receipts if developer mode is not enabled

* cmd/geth: degrade log level

* cmd/geth: fix format

Co-authored-by: Gary Rong <garyrong0905@gmail.com>
cp-wjhan pushed a commit to cp-yoonjin/go-wemix that referenced this pull request Nov 16, 2022
@jwasinger @rjl493456442 @cp-wjhan
cmd/geth: change to non-fatal error message when legacy receipt stora…
3ee98b7 
…ge is not implemented (ethereum#24603)

* cmd/geth: only check for presence of legacy receipts if developer mode is not enabled

* cmd/geth: degrade log level

* cmd/geth: fix format

Co-authored-by: Gary Rong <garyrong0905@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjl493456442 rjl493456442 rjl493456442 left review comments

@holiman holiman holiman approved these changes

@s1na s1na Awaiting requested review from s1na

Assignees
No one assigned
Labels
status:triage
Projects
None yet
Milestone
1.10.17
Development

Successfully merging this pull request may close these issues.

Geth crashes in dev mode with Failed to check for legacy receipts
4 participants
@jwasinger @karalabe @rjl493456442 @holiman