Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: add JWT secret log line #25095

Merged
merged 4 commits into from
Jun 15, 2022
Merged

node: add JWT secret log line #25095

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
33a9e1e
node: add JWT secret log line
MariusVanDerWijden Jun 15, 2022
d961279
node: better log
MariusVanDerWijden Jun 15, 2022
1eee315
Update node.go
fjl Jun 15, 2022
e282475
Update node.go
fjl Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions node/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,7 @@ func (n *Node) obtainJWTSecret(cliParam string) ([]byte, error) {
if data, err := os.ReadFile(fileName); err == nil {
jwtSecret := common.FromHex(strings.TrimSpace(string(data)))
if len(jwtSecret) == 32 {
log.Info("Read JWT secret", "path", fileName)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I've been thinking of, is if we should output even more info. Like, perhaps the crc32 checksum of the secret? It's annoying trying to figure out of EL and CL have the same secret.
Would be easier if they both spit out some low-entropy signature.. (?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like, how about something like this?

			log.Info("Read JWT secret", "path", fileName, "crc32", fmt.Sprintf("%#x", crc32.ChecksumIEEE(jwtSecret)))

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

INFO [06-15|10:17:36.628] Read JWT secret                          path=/media/ropsten/geth/jwtsecret crc32=0x4ce4e295

return jwtSecret, nil
}
log.Error("Invalid JWT secret", "path", fileName, "length", len(jwtSecret))
Expand Down