Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discv5 wormhole #25798

Closed
wants to merge 63 commits into from
Closed

discv5 wormhole #25798

wants to merge 63 commits into from

Conversation

lightclient
Copy link
Member

wip

lightclient and others added 30 commits September 17, 2022 00:28
Use kcp standard implementation for writing out
In readLoop, we use a single buffer for all packets. This is fine for
the uses of this buffer in UDPv5, but we cannot know how the reading end
of the 'unhandled' channel behaves, so must send a copy there.
Use kcp.NewConn3 for both client and server side, it accepts net.Addr
directly. Since we use TALKREQ to initiate the connection, the remote
address is available.
@fjl fjl self-assigned this Nov 22, 2022
@fjl fjl closed this Nov 22, 2022
fjl added a commit that referenced this pull request Dec 6, 2022
The new flag allows configuring an explicit endpoint which is to be
announced in the DHT. This feature was originally developed for the
discv5 wormhole experiment (#25798), but it's useful in other contexts
as well.
@holiman
Copy link
Contributor

holiman commented Feb 14, 2023

@fjl why did you close this??

@fjl
Copy link
Contributor

fjl commented Feb 14, 2023

I closed it because it was an experiment! I don't think we intend to ship it as a feature in cmd/devp2p?

@holiman
Copy link
Contributor

holiman commented Feb 14, 2023

I actually wanted this... 😢

@fjl
Copy link
Contributor

fjl commented Feb 14, 2023

We can always develop this further as a standalone tool! The prototype doesn't depend on any go-ethereum internals. It can also be added as a subcommand of cmd/devp2p, but I'd want to do some further development before that.

Either way, to get this in, we'd need to submit the p2p/discover fixes for Unhandled handling to master.

shekhirin pushed a commit to shekhirin/go-ethereum that referenced this pull request Jun 6, 2023
The new flag allows configuring an explicit endpoint which is to be
announced in the DHT. This feature was originally developed for the
discv5 wormhole experiment (ethereum#25798), but it's useful in other contexts
as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants