core: implement EIP-3651, warm coinbase #25819

MariusVanDerWijden · 2022-09-19T15:56:02Z

Implements https://eips.ethereum.org/EIPS/eip-3651 for Shanghai.

holiman · 2022-11-14T14:55:38Z

core/state_transition.go

@@ -320,6 +320,10 @@ func (st *StateTransition) TransitionDb() (*ExecutionResult, error) {
 	// Set up the initial access list.
 	if rules.IsBerlin {
 		st.state.PrepareAccessList(msg.From(), msg.To(), vm.ActivePrecompiles(rules), msg.AccessList())
+		// EIP-3651 warm COINBASE
+		if rules.IsShanghai {
+			st.state.AddAddressToAccessList(st.evm.Context.Coinbase)


This is not super-elegant, adding it like this means it's a journalled change. So it would be nicer to somehow integrate more closely in the "constructor" PrepareAccessList

Also, there are a few other places where PrepareAccessList is invoked (e.g. core/vm/runtime/runtime.go:Create) which also needs to do this extra step, and are currently not.
If we turn it into only one step, then we don't have to worry about missing the warm-coinbase extra-step

How about changing the PrepareAccessList into

func (s *StateDB) PrepareAccessList(sender, coinbase common.Address, dst *common.Address, precompiles []common.Address, list types.AccessList, rules params.Rules) {

I.e: adding coinbase common.Address, and also adding rules params.Rules, so the method can add the coinbase if we're in shanghai.

With the transient eip pr, the signature is changed (https://github.com/ethereum/go-ethereum/pull/26003/files#diff-c3757dc9e9d868f63bc84a0cc67159c1d5c22cc5d8c9468757098f0492e0658cR1071) , into

func (s *StateDB) Prepare(rules params.Rules, sender common.Address, dst *common.Address, precompiles []common.Address, list types.AccessList) {

So you only need to add the coinbase

holiman · 2022-11-16T09:50:58Z

I have now pushed a couple of changes,

Now the warm-coinbase logic happens inside Prepare, so it's not something a caller can get wrong.
The initial access list additions are now not journalled. This is a change which I think is totally fine, but would appreciate if someone also thinks about and comes to the same conclusion (or not).

rjl493456442 · 2022-11-17T04:47:35Z

core/state/statedb.go

@@ -1068,25 +1068,29 @@ func (s *StateDB) Commit(deleteEmptyObjects bool) (common.Hash, error) {
 //
 // Potential EIPs:
 // - Reset transient storage(1153)
-func (s *StateDB) Prepare(rules params.Rules, sender common.Address, dst *common.Address, precompiles []common.Address, list types.AccessList) {
+func (s *StateDB) Prepare(rules params.Rules, sender, coinbase common.Address, dst *common.Address, precompiles []common.Address, list types.AccessList) {


Nitpick, can you also add the Shanghai Fork information here:

e.g.

Shanghai fork:

Add coinbase to access list(3651)

rjl493456442

Just a nitpick, I feel like it's safe to not journal initial accessList change. These change will never be rollback IIUC.

But yeah, we can run the PR on a synced node, just ensure nothing broken?

holiman · 2022-11-17T11:41:47Z

Nov 17 12:40:43 bench01.ethdevops.io geth INFO [11-17|11:40:43.655] Starting peer-to-peer node instance=Geth/v1.11.0-unstable-e6af3a14-20221116/linux-amd64/go1.18.7

It's chugging along now, started at full block number=15,945,345, currently at number=15,947,346

MariusVanDerWijden

Changes LGTM, can't approve since I'm author

holiman · 2022-11-22T19:20:07Z

Follow-up

 Nov 22 20:19:02 bench01.ethdevops.io geth INFO [11-22|19:19:02.118] Imported new potential chain segment number=16,027,581 hash=d31241..53c342 blocks=1 txs=...

All good

holiman · 2022-11-22T20:36:04Z

tests/state_test.go

@@ -28,6 +28,7 @@ import (
 	"testing"
 	"time"

+	"github.com/ethereum/go-ethereum/common"


>>> build/cache/golangci-lint-1.49.0-linux-amd64/golangci-lint run --config .golangci.yml ./... tests/state_test.go:31:2: "github.com/ethereum/go-ethereum/common" imported but not used (typecheck) "github.com/ethereum/go-ethereum/common" ^ util.go:48: exit status 1

tests/state_test.go

core/state/statedb.go

holiman

LGTM

core/state/statedb.go

Implements EIP-3651, "Warm Coinbase", for Shanghai hardfork. Specification: https://eips.ethereum.org/EIPS/eip-3651.

* core: implement EIP-3651, warm coinbase (ethereum#25819) Implements EIP-3651, "Warm Coinbase", for Shanghai hardfork. Specification: https://eips.ethereum.org/EIPS/eip-3651. * improve test * update to shanghai * trigger ci * fix comments --------- Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de>

Implements EIP-3651, "Warm Coinbase", for Shanghai hardfork. Specification: https://eips.ethereum.org/EIPS/eip-3651.

MariusVanDerWijden mentioned this pull request Sep 19, 2022

Shanghai tracking issue #25820

Closed

holiman added the maybe shanghai label Sep 26, 2022

MariusVanDerWijden marked this pull request as ready for review October 31, 2022 13:50

MariusVanDerWijden requested review from karalabe, holiman and rjl493456442 as code owners October 31, 2022 13:50

holiman reviewed Nov 14, 2022

View reviewed changes

MariusVanDerWijden and others added 3 commits November 16, 2022 10:34

core: implement EIP-3651, warm coinbase

dc26823

core: added test for warm coinbase

b8ce988

core/state, core/vm: modify prepare to handle warm coinbase

0341770

holiman force-pushed the eip-3651 branch from d92746f to 0341770 Compare November 16, 2022 09:42

core/state: avoid journalling when initializing accesslist

e6af3a1

rjl493456442 reviewed Nov 17, 2022

View reviewed changes

rjl493456442 approved these changes Nov 17, 2022

View reviewed changes

MariusVanDerWijden commented Nov 21, 2022

View reviewed changes

holiman reviewed Nov 22, 2022

View reviewed changes

tests/state_test.go Outdated Show resolved Hide resolved

holiman reviewed Nov 22, 2022

View reviewed changes

core/state/statedb.go Outdated Show resolved Hide resolved

Apply suggestions from code review

6845e47

holiman approved these changes Nov 22, 2022

View reviewed changes

holiman reviewed Nov 22, 2022

View reviewed changes

core/state/statedb.go Outdated Show resolved Hide resolved

Update core/state/statedb.go

e22c08d

holiman merged commit ec2ec2d into ethereum:master Nov 22, 2022

holiman added this to the 1.11.0 milestone Nov 22, 2022

This was referenced Feb 11, 2023

Tracking: Shanghai Support paradigmxyz/reth#1295

Closed

Add EIP-3651 for Shanghai support bluealloy/revm#370

Closed

NazariiDenha pushed a commit to scroll-tech/go-ethereum that referenced this pull request May 9, 2023

core: implement EIP-3651, warm coinbase (ethereum#25819)

ed17b5a

Implements EIP-3651, "Warm Coinbase", for Shanghai hardfork. Specification: https://eips.ethereum.org/EIPS/eip-3651.

shekhirin pushed a commit to shekhirin/go-ethereum that referenced this pull request Jun 6, 2023

core: implement EIP-3651, warm coinbase (ethereum#25819)

365588a

Implements EIP-3651, "Warm Coinbase", for Shanghai hardfork. Specification: https://eips.ethereum.org/EIPS/eip-3651.

yoomee1313 mentioned this pull request Jul 18, 2023

evm: warm coinbase (eip-3651) klaytn/klaytn#1883

Merged

9 tasks

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 2, 2024

core: implement EIP-3651, warm coinbase (ethereum#25819)

3a33947

gzliudan mentioned this pull request Oct 2, 2024

all: implement EIP-1153(transient storage) XinFinOrg/XDPoSChain#647

Merged

19 tasks

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 16, 2024

core: implement EIP-3651, warm coinbase (ethereum#25819)

53409ac

gzliudan mentioned this pull request Oct 16, 2024

implement EIP-3651(warm coinbase) XinFinOrg/XDPoSChain#677

Open

19 tasks

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 17, 2024

core: implement EIP-3651, warm coinbase (ethereum#25819)

2a21115

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 18, 2024

core: implement EIP-3651, warm coinbase (ethereum#25819)

e4502ce

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024

core: implement EIP-3651, warm coinbase (ethereum#25819)

ca99e66

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 29, 2024

core: implement EIP-3651, warm coinbase (ethereum#25819)

2fb97a3

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 30, 2024

core: implement EIP-3651, warm coinbase (ethereum#25819)

31a86b6

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024

core: implement EIP-3651, warm coinbase (ethereum#25819)

ae52dff

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 1, 2024

core: implement EIP-3651, warm coinbase (ethereum#25819)

7281c09

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 15, 2024

core: implement EIP-3651, warm coinbase (ethereum#25819)

0f96bdc

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 15, 2024

core: implement EIP-3651, warm coinbase (ethereum#25819)

4265f2c

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 15, 2024

core: implement EIP-3651, warm coinbase (ethereum#25819)

4cebec1

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 18, 2024

core: implement EIP-3651, warm coinbase (ethereum#25819)

65f6188

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 20, 2024

core: implement EIP-3651, warm coinbase (ethereum#25819)

08e9592

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 21, 2024

core: implement EIP-3651, warm coinbase (ethereum#25819)

096ceb4

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 25, 2024

core: implement EIP-3651, warm coinbase (ethereum#25819)

080edbd

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 25, 2024

core: implement EIP-3651, warm coinbase (ethereum#25819)

074f1de

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 2, 2024

core: implement EIP-3651, warm coinbase (ethereum#25819)

0128dbd

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 2, 2024

core: implement EIP-3651, warm coinbase (ethereum#25819)

8befde6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

core: implement EIP-3651, warm coinbase #25819

core: implement EIP-3651, warm coinbase #25819

MariusVanDerWijden commented Sep 19, 2022 •

edited

Loading

holiman Nov 14, 2022

holiman Nov 14, 2022

holiman Nov 14, 2022

holiman Nov 16, 2022

holiman commented Nov 16, 2022

rjl493456442 Nov 17, 2022

rjl493456442 left a comment

holiman commented Nov 17, 2022 •

edited

Loading

MariusVanDerWijden left a comment

holiman commented Nov 22, 2022

holiman Nov 22, 2022

holiman left a comment

core: implement EIP-3651, warm coinbase #25819

core: implement EIP-3651, warm coinbase #25819

Conversation

MariusVanDerWijden commented Sep 19, 2022 • edited Loading

holiman Nov 14, 2022

Choose a reason for hiding this comment

holiman Nov 14, 2022

Choose a reason for hiding this comment

holiman Nov 14, 2022

Choose a reason for hiding this comment

holiman Nov 16, 2022

Choose a reason for hiding this comment

holiman commented Nov 16, 2022

rjl493456442 Nov 17, 2022

Choose a reason for hiding this comment

rjl493456442 left a comment

Choose a reason for hiding this comment

holiman commented Nov 17, 2022 • edited Loading

MariusVanDerWijden left a comment

Choose a reason for hiding this comment

holiman commented Nov 22, 2022

holiman Nov 22, 2022

Choose a reason for hiding this comment

holiman left a comment

Choose a reason for hiding this comment

MariusVanDerWijden commented Sep 19, 2022 •

edited

Loading

holiman commented Nov 17, 2022 •

edited

Loading