rpc: support inject http headers using outgoing context #26023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: storyicon <yuanchao@bilibili.com>
Co-authored-by: Martin Holst Swende <martin@swende.se>
Co-authored-by: Martin Holst Swende <martin@swende.se>
Signed-off-by: storyicon <yuanchao@bilibili.com>
Signed-off-by: storyicon <yuanchao@bilibili.com>
|
@holiman thanks, I adopted some of your suggestions and simplified the design. Now it has become clearer about the requirement of |
holiman
requested changes
Oct 24, 2022
holiman
reviewed
Oct 24, 2022
Signed-off-by: storyicon <yuanchao@bilibili.com>
|
I pushed a change now, mostly small things, but one functional change -- it now supports multiple contexts setting headers sequentially. Please take a look. I think this is ok now, leaving it to @fjl to decide about |
Signed-off-by: storyicon <yuanchao@bilibili.com>
|
I have also made some changes to make the logic clearer. At the same time, |
holiman
reviewed
Oct 28, 2022
Co-authored-by: Martin Holst Swende <martin@swende.se>
Co-authored-by: Martin Holst Swende <martin@swende.se>
|
Nah, don't worry, he'll get to it eventually. We are slow with PRs often, let it take it's time
|
Thank you for actively addressing this issue. |
fjl
approved these changes
Nov 16, 2022
shekhirin
pushed a commit
to shekhirin/go-ethereum
that referenced
this pull request
Jun 6, 2023
This adds a way to specify HTTP headers per request. Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Felix Lange <fjl@twurst.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is used to solve: #26004
Signed-off-by: storyicon yuanchao@bilibili.com