-
Notifications
You must be signed in to change notification settings - Fork 20k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/clef: list accounts at startup #26082
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
600780f
dumps account info at startup
jmcook1186 d932ac6
fix accidental ctrl-v
jmcook1186 155ea96
fix account listing
jmcook1186 82df060
Merge branch 'master' of https://github.com/jmcook1186/go-ethereum in…
jmcook1186 1533a58
+ account details to Startupinfo map for ui to print
jmcook1186 0176fa0
register API and call listAccounts from cliui
jmcook1186 56e46c3
account listing -> separate func, rm whitespace
jmcook1186 adc44ff
minimize print statements by bundling info into str
jmcook1186 c1dbc02
make call to showAccounts async
jmcook1186 4131ddd
minimize go func, rm whitespace
jmcook1186 cffb417
signer/core: minor changes in cliui account display
holiman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Myeah, sure, that's one way of doing it. If you do this, then you should make it lowercase - so it's a non-public method
showAccounts
.But the primary thing I wanted was to make it async. So instead of just calling
You would do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, yes ok: c1dbc02