Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/evm: slight change in how t8n handles coinbase pre eip-158 #26139

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Nov 8, 2022

This PR fixes a subtle bug in t8n. After this PR, t8n behaves like our state-test runner in this particular scenario:

  • After an empty block,
  • And the config is that there is a zero block reward,
  • And the coinbase did not previously exist,
  • And we're before EIP-158,
  • Then the coinbase should be touched, a.k.a brought into existence.

Our state test runner handles that here: https://github.com/ethereum/go-ethereum/blob/master/tests/state_test_util.go#L266

The t8n was meant to handle that exactly identical, but failed to do so. That's what's being fixed by this PR.
Also related, the miningReward comes from this flag:

	RewardFlag = &cli.Int64Flag{
		Name:  "state.reward",
		Usage: "Mining reward. Set to -1 to disable",
		Value: 0,
	}

cc @winsvega

@winsvega
Copy link
Contributor

winsvega commented Nov 8, 2022

Would like to point out that besu client discovered that by test RPC

@holiman holiman added this to the 1.11.0 milestone Nov 9, 2022
@holiman holiman merged commit dffd93b into ethereum:master Nov 9, 2022
shekhirin pushed a commit to shekhirin/go-ethereum that referenced this pull request Jun 6, 2023
…eum#26139)

This PR fixes a subtle bug in t8n. After this PR, t8n behaves like our state-test runner in certain pre-EIP-158 scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants