Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth, catalyst: fix flaky tests #26153

Merged
merged 2 commits into from
Nov 11, 2022
Merged

eth, catalyst: fix flaky tests #26153

merged 2 commits into from
Nov 11, 2022

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Nov 10, 2022

This is another PR to fix flaky tests, mostly due to built-in synchronicity requirements which do not work very well on the low-resource appveyor machines.

Fix 1:

--- FAIL: TestNewPayloadOnInvalidChain (0.14s)
    api_test.go:604: payload should not be empty

Fix 2:

--- FAIL: TestTransactionPropagation67 (1.76s)
    handler_eth_test.go:455: sink 0: transaction propagation timed out: have 0, want 1024
INFO [11-10|03:48:40.490] Writing custom genesis block 

@holiman holiman marked this pull request as ready for review November 10, 2022 10:34
@holiman holiman merged commit ea65eda into ethereum:master Nov 11, 2022
@holiman holiman added this to the 1.11.0 milestone Nov 11, 2022
shekhirin pushed a commit to shekhirin/go-ethereum that referenced this pull request Jun 6, 2023
* eth/catalyst: fix time-dependent (flaky) test

* eth: increase timeout on TestTransactionPropagation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant