Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: minimum Go version 1.18 #26160

Merged
merged 1 commit into from
Nov 11, 2022
Merged

go.mod: minimum Go version 1.18 #26160

merged 1 commit into from
Nov 11, 2022

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Nov 11, 2022

This will allow use of generics and other new standard library APIs such as package net/netip.

@holiman
Copy link
Contributor

holiman commented Nov 11, 2022

You can also remove the vcs_fallback.go, and update the Dockerfile(s), currently:

FROM golang:1.18-alpine as builder

@fjl
Copy link
Contributor Author

fjl commented Nov 11, 2022

You can also remove the vcs_fallback.go

Our strategy for old-Go support code has usuallly been that we leave it in place.
That way, some packages can still be built with older versions.

@fjl
Copy link
Contributor Author

fjl commented Nov 11, 2022

I'll update Dockerfile in a separate PR

@fjl fjl merged commit 62c973e into ethereum:master Nov 11, 2022
@fjl fjl added this to the 1.11.0 milestone Nov 11, 2022
shekhirin pushed a commit to shekhirin/go-ethereum that referenced this pull request Jun 6, 2023
This will allow use of generics and other new standard library APIs
such as package net/netip.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants