core/vm: implement EIP-5656, mcopy instruction #26181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-cooper
requested review from
karalabe,
holiman and
rjl493456442
as code owners
|
mentioning: ethereum/EIPs#5656 |
gumb0
reviewed
Nov 30, 2022
gumb0
reviewed
Nov 30, 2022
gumb0
reviewed
Nov 30, 2022
lightclient
reviewed
Apr 27, 2023
holiman
reviewed
Jun 8, 2023
There was a problem hiding this comment.
LGTM, but please also add the unit-tests from the EIP: https://eips.ethereum.org/EIPS/eip-5656#test-cases
holiman
reviewed
Jun 8, 2023
holiman
reviewed
Jun 8, 2023
You got pretty far for not knowing go, but I can take from you on adding the testcases if you want. |
|
thanks! also updated the opcode location per ethereum/EIPs#7155 in 3fb5a5d |
|
@holiman anything else needed from me at this time? |
0xJepsen
reviewed
Jun 22, 2023
|
This PR now passes this test:https://github.com/ipsilon/tests/blob/2379e3335868f9c1c68dcf2eed0b404121369126/EIPTests/StateTests/stEIP5656-MCOPY/MCOPY_memory_hash.json , via |
holiman
changed the title
lightclient
approved these changes
Jul 10, 2023
yperbasis
added a commit
to erigontech/erigon
that referenced
this pull request
Jul 13, 2023
Cherry pick ethereum/go-ethereum#26181 Co-authored-by: Charles Cooper <cooper.charles.m@gmail.com>
AskAlexSharov
pushed a commit
to erigontech/erigon
that referenced
this pull request
Sep 6, 2023
Cherry pick ethereum/go-ethereum#26181 Co-authored-by: Charles Cooper <cooper.charles.m@gmail.com>
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
Implements [EIP 5656](https://eips.ethereum.org/EIPS/eip-5656), MCOPY instruction, and enables it for Cancun. --------- Co-authored-by: Martin Holst Swende <martin@swende.se>
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit b0a5097.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit b0a5097.
NazariiDenha
pushed a commit
to scroll-tech/go-ethereum
that referenced
this pull request
Apr 9, 2024
Implements [EIP 5656](https://eips.ethereum.org/EIPS/eip-5656), MCOPY instruction, and enables it for Cancun. --------- Co-authored-by: Martin Holst Swende <martin@swende.se>
Thegaram
added a commit
to scroll-tech/go-ethereum
that referenced
this pull request
Apr 24, 2024
* core/vm: implement EIP-5656, mcopy instruction (ethereum#26181) Implements [EIP 5656](https://eips.ethereum.org/EIPS/eip-5656), MCOPY instruction, and enables it for Cancun. --------- Co-authored-by: Martin Holst Swende <martin@swende.se> * update version * goimports --------- Co-authored-by: Charles Cooper <cooper.charles.m@gmail.com> Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Péter Garamvölgyi <peter@scroll.io> Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first attempt at implementing the MCOPY instruction.
I don't actually know Go, so I mostly adopted the
opCallDataCopyimplementation.