Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethclient: docs, fix misleading comment #26189

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Conversation

ligi
Copy link
Member

@ligi ligi commented Nov 16, 2022

closes #26188

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman changed the title ethclient: Fix misleading documentation ethclient: docs, fix misleading comment Nov 16, 2022
@holiman holiman added this to the 1.11.0 milestone Nov 16, 2022
@holiman holiman merged commit bc90a88 into ethereum:master Nov 16, 2022
shekhirin pushed a commit to shekhirin/go-ethereum that referenced this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: network ID is not chain ID
2 participants