Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rlp: improve tests for Split functions #26200

Merged
merged 4 commits into from
Nov 17, 2022

Conversation

therainisme
Copy link
Contributor

This PR updates error message.

rlp/raw_test.go Outdated Show resolved Hide resolved
rlp/raw_test.go Outdated Show resolved Hide resolved
rlp/raw_test.go Outdated Show resolved Hide resolved
rlp/raw_test.go Outdated Show resolved Hide resolved
rlp/raw_test.go Outdated Show resolved Hide resolved
@fjl fjl changed the title rlp/raw_test: update error message rlp: improve tests for Split functions Nov 17, 2022
@therainisme
Copy link
Contributor Author

I got it, thanks a lot for the suggestions.

@therainisme
Copy link
Contributor Author

I'm new here lol thanks for your patience.

rlp/raw_test.go Outdated Show resolved Hide resolved
rlp/raw_test.go Outdated Show resolved Hide resolved
@holiman
Copy link
Contributor

holiman commented Nov 17, 2022

I'm new here lol thanks for your patience.

Don't worry about it, thank you for your patience!

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@holiman holiman added this to the 1.11.0 milestone Nov 17, 2022
@holiman holiman merged commit 722bb21 into ethereum:master Nov 17, 2022
@therainisme therainisme deleted the update-error-message branch November 18, 2022 06:14
shekhirin pushed a commit to shekhirin/go-ethereum that referenced this pull request Jun 6, 2023
This PR improves and extends the tests a bit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants