Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/utils: print warning when --metrics.port set without --metrics.addr #26248

Merged
merged 2 commits into from
Nov 24, 2022
Merged

cmd/utils: print warning when --metrics.port set without --metrics.addr #26248

merged 2 commits into from
Nov 24, 2022

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Nov 24, 2022 •
edited
Loading

Fixes #26244

holiman
holiman approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjl fjl merged commit 8846c07 into ethereum:master Nov 24, 2022
@fjl fjl added this to the 1.11.0 milestone Nov 24, 2022
shekhirin pushed a commit to shekhirin/go-ethereum that referenced this pull request Jun 6, 2023
@fjl @shekhirin
cmd/utils: print warning when --metrics.port set without --metrics.ad…
626774e 
…dr (ethereum#26248)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

Metrics not starting
2 participants
@fjl @holiman