all: activate pbss as experimental feature #26274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
requested review from
zsfelfoldi,
s1na,
karalabe and
holiman
as code owners
rjl493456442
force-pushed
the
activate-pbss-2
branch
2 times, most recently
from
4049899
to
8a7b676
Compare
rjl493456442
force-pushed
the
activate-pbss-2
branch
from
8a7b676
to
eb57884
Compare
rjl493456442
force-pushed
the
activate-pbss-2
branch
from
eb57884
to
4273558
Compare
rjl493456442
force-pushed
the
activate-pbss-2
branch
3 times, most recently
from
5e9521d
to
3688352
Compare
rjl493456442
force-pushed
the
activate-pbss-2
branch
2 times, most recently
from
fe8258e
to
5fcf220
Compare
rjl493456442
force-pushed
the
activate-pbss-2
branch
from
5fcf220
to
8b47549
Compare
rjl493456442
force-pushed
the
activate-pbss-2
branch
2 times, most recently
from
7f94d50
to
ecaf4ab
Compare
rjl493456442
force-pushed
the
activate-pbss-2
branch
from
ecaf4ab
to
b37cc4e
Compare
|
how does #25963 differ / relate to this branch? |
|
This one activates PBSS, while the other one implements it. @rjl493456442 split the two in order to make the review easier |
|
Hi. Is this still being worked on ? |
Yes |
rjl493456442
force-pushed
the
activate-pbss-2
branch
2 times, most recently
from
21a9df2
to
7ecaff2
Compare
rjl493456442
force-pushed
the
activate-pbss-2
branch
from
7ecaff2
to
1370bb8
Compare
karalabe
reviewed
Aug 8, 2023
| @@ -246,6 +247,10 @@ func handleGetNodeData66(backend Backend, msg Decoder, peer *Peer) error { | |||
| // ServiceGetNodeDataQuery assembles the response to a node data query. It is | |||
| // exposed to allow external packages to test protocol behavior. | |||
| func ServiceGetNodeDataQuery(chain *core.BlockChain, query GetNodeDataPacket) [][]byte { | |||
| // Request nodes by hash is not supported in path-based scheme. | |||
| if chain.TrieDB().Scheme() == rawdb.PathScheme { | |||
| return nil | |||
There was a problem hiding this comment.
Should we perhaps drop eth/xx that has GetNodeData?
karalabe
reviewed
Aug 8, 2023
karalabe
reviewed
Aug 8, 2023
karalabe
reviewed
Aug 8, 2023
karalabe
reviewed
Aug 8, 2023
karalabe
reviewed
Aug 8, 2023
karalabe
reviewed
Aug 8, 2023
holiman
reviewed
Aug 8, 2023
| @@ -1341,6 +1398,11 @@ func (bc *BlockChain) writeBlockWithState(block *types.Block, receipts []*types. | |||
| if err != nil { | |||
| return err | |||
| } | |||
| // If node is running in path mode, skip explicit gc operation | |||
| // which is unnecessary in this mode. | |||
There was a problem hiding this comment.
Nice. Later on (not this PR), it might be neat to move the gc-stuff away.
So we have
if bc.triedb.Scheme() == rawdb.PathScheme {
return nil
}
// Hashdb requires explicit gc / flushing
blockchain.doHashdbGc(a,b,c...)
karalabe
reviewed
Aug 9, 2023
karalabe
reviewed
Aug 9, 2023
karalabe
reviewed
Aug 9, 2023
karalabe
reviewed
Aug 9, 2023
karalabe
reviewed
Aug 9, 2023
karalabe
reviewed
Aug 9, 2023
karalabe
approved these changes
Aug 10, 2023
weiihann
pushed a commit
to weiihann/go-ethereum
that referenced
this pull request
Aug 15, 2023
* all: activate pbss * core/rawdb: fix compilation error * cma, core, eth, les, trie: address comments * cmd, core, eth, trie: polish code * core, cmd, eth: address comments * cmd, core, eth, les, light, tests: address comment * cmd/utils: shorten log message * trie/triedb/pathdb: limit node buffer size to 1gb * cmd/utils: fix opening non-existing db * cmd/utils: rename flag name * cmd, core: group chain history flags and fix tests * core, eth, trie: fix memory leak in snapshot generation * cmd, eth, internal: deprecate flags * all: enable state tests for pathdb, fixes * cmd, core: polish code * trie/triedb/pathdb: limit the node buffer size to 256mb --------- Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Péter Szilágyi <peterke@gmail.com> # Conflicts: # cmd/evm/runner.go # cmd/evm/staterunner.go # cmd/geth/chaincmd.go # core/chain_makers.go # core/rawdb/database.go # core/state/statedb_test.go # core/state/sync_test.go # eth/state_accessor.go # miner/miner_test.go # tests/state_test_util.go
holiman
added a commit
that referenced
this pull request
Aug 22, 2023
The PR #26274 broke the evm statetest command a bit, in that it stopped spitting out the stateroot following a non-successful statetest-execution. This PR changes it back, so the stateroot is unconditionally output on stderr, and makes it so fuzzing works again.
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
* all: activate pbss * core/rawdb: fix compilation error * cma, core, eth, les, trie: address comments * cmd, core, eth, trie: polish code * core, cmd, eth: address comments * cmd, core, eth, les, light, tests: address comment * cmd/utils: shorten log message * trie/triedb/pathdb: limit node buffer size to 1gb * cmd/utils: fix opening non-existing db * cmd/utils: rename flag name * cmd, core: group chain history flags and fix tests * core, eth, trie: fix memory leak in snapshot generation * cmd, eth, internal: deprecate flags * all: enable state tests for pathdb, fixes * cmd, core: polish code * trie/triedb/pathdb: limit the node buffer size to 256mb --------- Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Péter Szilágyi <peterke@gmail.com>
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
The PR ethereum#26274 broke the evm statetest command a bit, in that it stopped spitting out the stateroot following a non-successful statetest-execution. This PR changes it back, so the stateroot is unconditionally output on stderr, and makes it so fuzzing works again.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 1053526.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 1053526.
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Nov 29, 2023
* all: activate pbss * core/rawdb: fix compilation error * cma, core, eth, les, trie: address comments * cmd, core, eth, trie: polish code * core, cmd, eth: address comments * cmd, core, eth, les, light, tests: address comment * cmd/utils: shorten log message * trie/triedb/pathdb: limit node buffer size to 1gb * cmd/utils: fix opening non-existing db * cmd/utils: rename flag name * cmd, core: group chain history flags and fix tests * core, eth, trie: fix memory leak in snapshot generation * cmd, eth, internal: deprecate flags * all: enable state tests for pathdb, fixes * cmd, core: polish code * trie/triedb/pathdb: limit the node buffer size to 256mb --------- Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Péter Szilágyi <peterke@gmail.com>
sduchesneau
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Feb 26, 2024
Additions: eth/state_accessors.go: Made StateAtBlock public Conflicts: core/blockchain.go: Upstream changes to setHeadBeyondRoot were taken, while keeping our extra logic limiting rewind. core/state/pruner/pruner.go: trie.NewDatabase accepts new parameter. moved the change from where it was made upstream to where we use the same code eth/state_accessor.go: trie/triedb/hashdb/database.go trie/triedb/pathdb/database.go: we had logic to clear caches avoiding memory leaks. Upstream implemented their own solutions - use upstream solution in these cases. eth/backend.go tests/block_test_util.go core/block_validator_test.go core/blockchain_repair_test.go core/blockchain_sethead_test.go core/blockchain_snapshot_test.go core/blockchain_test.go core/chain_makers_test.go core/genesis_test.go many conflicts, mostly in tests were either due to: * changes in params to NewBlockChain -> we have an extra parameter set to nill, used updated calls with our extra nil param * tests using TriesInMemory which we renamed to DefaultTriesInMemory (took changes and updated to our name) * getting triedb config from cacheconfig, which now has a dedicated function. I used the new function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.