cmd/bootnode, p2p: use an alternate mapped port #26359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the wait, I'm on leave until next year. |
* temp * rede * remove meaningless field * temp comment * set refresh time to param * server: use channel enr.Entry * server: rename `changedport` to `changeport` * server: apply new nat-refresh `ethereum discovery` * p2p/nat: add some comment * p2p/nat: use `DefaultMapTimeout` * p2p: fixed * p2p/server: impr * p2p/server: syntax change * cmd/bootnode: add comments * add p2p.Server changeport * all: fix comments * p2p/server: syntax changes * cmd/bootnode: do not change UDPAddr Port * p2p: remove incorrect `for` context * p2p: add what needs to be addressed * p2p/nat: use AddPortMapping if supported * asynchronous port set * remove unused variables * change return format in `changePort` * cmd/bootnode: consistent log * p2p/server: rename `refreshLogger` to `newLogger` * cmd/bootnode: fix incorrect if-else * fix * change log orders * rename `natRefresh` to `natMapLoop` * p2p: remove `changeport` in Server main loop * server: remove duplicate code * typo * typo * cmd/bootnode: consistent log message * p2p: fix comments test code about port change on localnode cmd/bootnode: add log improve test logic , add some comments p2p/nat: add comments about not supported p2p: remove unnecessary conversion in test fix test failure, not setting TCP on localnode remove note checks mapped port first
Better to do it like this because the external IP needs to be polled as well.
|
This should be ready now! |
|
It looks really good! I made a small change. |
dbadoy
commented
Jul 12, 2023
lightclient
approved these changes
Jul 12, 2023
fjl
changed the title
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This changes the port mapping procedure such that, when the requested port is unavailable an alternative port suggested by the router is used instead. We now also repeatedly request the external IP from the router in order to catch any IP changes. Co-authored-by: Felix Lange <fjl@twurst.com>
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This was referenced Feb 1, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NAT-PMP maps an alternate port if the requested port is already in use and returns success. The current implementation define by 'failure' if the request port and the actual mapped port are different. Therefore it simply kept logging the message that 'Couldn't add port mapping' until the port was available again if the previously requested port was already used.
The goal of this PR is to have normal operation using an alternative port number even if the originally intended port is unavailable on NAT.
started from #26321 (comment), dbadoy#1