Use filepath.clean instead of path.clean #26404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusVanDerWijden
force-pushed
the
filepath-clean
branch
from
2b1b6c1
to
5ef2e44
Compare
rjl493456442
approved these changes
Jan 3, 2023
|
Failing test: i.e |
|
Named pipe paths are not file paths, they exist in a separate namespace on windows and should not be expanded by this function. Probably best to add a special case for paths starting with |
holiman
reviewed
Jan 9, 2023
holiman
reviewed
Jan 9, 2023
holiman
reviewed
Jan 9, 2023
internal/flags/flags_test.go
Outdated
| "~thisOtherUser/b/": "~thisOtherUser/b", | ||
| "$DDDXXX/a/b": "/tmp/a/b", | ||
| "/a/b/": "/a/b", | ||
| "C:\\Documents\\Newsletters\\": "C:\\Documents\\Newsletters\\", |
There was a problem hiding this comment.
Is this correct? Shouldn't the expansion use / path separators?
Suggested change
| "C:\\Documents\\Newsletters\\": "C:\\Documents\\Newsletters\\", | |
| "C:\\Documents\\Newsletters\\": "C:\\Documents\\Newsletters\\", |
shekhirin
pushed a commit
to shekhirin/go-ethereum
that referenced
this pull request
Jun 6, 2023
* internal/flags: use filepath.Clean instead of path.Clean * internal/flags: fix windows pipe issue * internal/flags: modify test for windows * internal/flags: use backticks, fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #22367
NOT TESTED UNDER WINDOWS