eth/downloader: fix cornercase when clean stale beacon headers #26441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
approved these changes
Jan 10, 2023
|
Let's wait Peter on it. It's really unlikely to be triggered, priority is not that high. |
fjl
approved these changes
Jan 12, 2023
shekhirin
pushed a commit
to shekhirin/go-ethereum
that referenced
this pull request
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a special corner case when cleaning up stale beacon headers.
Though I think it's really hard to happen, just submit the fix anyway.
For example, the scenario could be:
In this case, a new skeleton subchain will be created {tail=6, head=6} and all other
subchains will be dropped. The beacon header 6 is also expected to be persisted.
But originally, in this case, beacon header 6 is not persisted for some reasons. This
PR fixes this issue.