Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/types, params: add blob transaction type, RLP encoded for now #27049

Merged
merged 5 commits into from
Apr 21, 2023

Conversation

karalabe
Copy link
Member

@karalabe karalabe commented Apr 4, 2023

This PR is another subset of 4844. The purpose is to introduce the new transaction type for blobs, extend the generic transaction interface with the getters needed by blob txs and to add the signer that can sign and recover these new transaction types.

For now the blob txs use RLP, since SSZ integration will be a different step where the scope should be formatting, not type extensions.

@karalabe karalabe added this to the 1.11.6 milestone Apr 4, 2023
@karalabe karalabe mentioned this pull request Apr 4, 2023
26 tasks
core/types/transaction.go Outdated Show resolved Hide resolved
@ethereum ethereum deleted a comment Apr 6, 2023
@Mholt74
Copy link

Mholt74 commented Apr 7, 2023


@Szybka22
Copy link

gh pr checkout 27087

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems most changes are not related to blob-txs per se, but rather making the signer timestamp-aware.

core/state_processor.go Outdated Show resolved Hide resolved
core/types/tx_blob.go Outdated Show resolved Hide resolved
@holiman holiman modified the milestones: 1.11.6, 1.11.7 Apr 20, 2023
@karalabe karalabe merged commit bbc565a into ethereum:master Apr 21, 2023
shekhirin pushed a commit to shekhirin/go-ethereum that referenced this pull request Jun 6, 2023
…thereum#27049)

* core/types, params: add blob transaction type, RLP encoded for now

* all: integrate Cancun (and timestamp based forks) into MakeSigner

* core/types: fix 2 back-and-forth type refactors

* core: fix review comment

* core/types: swap blob tx type id to 0x03
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
…thereum#27049)

* core/types, params: add blob transaction type, RLP encoded for now

* all: integrate Cancun (and timestamp based forks) into MakeSigner

* core/types: fix 2 back-and-forth type refactors

* core: fix review comment

* core/types: swap blob tx type id to 0x03
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants