light: use atomic type #27169
Merged
light: use atomic type #27169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
light/lightchain.go
Outdated
| @@ -302,7 +302,7 @@ func (lc *LightChain) GetBlockByNumber(ctx context.Context, number uint64) (*typ | |||
| // Stop stops the blockchain service. If any imports are currently in progress | |||
| // it will abort them using the procInterrupt. | |||
| func (lc *LightChain) Stop() { | |||
| if !atomic.CompareAndSwapInt32(&lc.running, 0, 1) { | |||
| if !lc.running.CompareAndSwap(false, true) { | |||
There was a problem hiding this comment.
This variable name is weird. Perhaps stopped is more suitable.
There was a problem hiding this comment.
Thanks for the reminder, it has been modified.
shekhirin
pushed a commit
to shekhirin/go-ethereum
that referenced
this pull request
Jun 6, 2023
* light: use atomic type * light: use a suitable name for the stopped switch in LightChain
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
* light: use atomic type * light: use a suitable name for the stopped switch in LightChain
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 422f4b4.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 422f4b4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use atomic.Bool for switches in light.LightChain