core/txpool : fix map size avoid resizing #27221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
reviewed
May 5, 2023
core/txpool/txpool.go
Outdated
| @@ -581,7 +581,7 @@ func (pool *TxPool) Locals() []common.Address { | |||
| // account and sorted by nonce. The returned transaction set is a copy and can be | |||
| // freely modified by calling code. | |||
| func (pool *TxPool) local() map[common.Address]types.Transactions { | |||
| txs := make(map[common.Address]types.Transactions) | |||
| txs := make(map[common.Address]types.Transactions, len(pool.locals.accounts)) | |||
There was a problem hiding this comment.
This is not that obvious. There may be many local accounts but no transactions from them.
There was a problem hiding this comment.
This is not that obvious. There may be many local accounts but no transactions from them.
Yes, it may be, for some public RPC nodes?
shekhirin
pushed a commit
to shekhirin/go-ethereum
that referenced
this pull request
Jun 6, 2023
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit cd43de7.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit cd43de7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.