ethclient: acquire the rpc.Client #27246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jsvisa <delweng@gmail.com>
shekhirin
pushed a commit
to shekhirin/go-ethereum
that referenced
this pull request
Jun 6, 2023
Signed-off-by: jsvisa <delweng@gmail.com>
prestonvanloon
added a commit
to OffchainLabs/bold
that referenced
this pull request
Aug 1, 2023
prestonvanloon
added a commit
to OffchainLabs/bold
that referenced
this pull request
Aug 1, 2023
prestonvanloon
added a commit
to OffchainLabs/bold
that referenced
this pull request
Aug 1, 2023
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
Signed-off-by: jsvisa <delweng@gmail.com>
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 5ac6bd2.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 5ac6bd2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why do we need to return the
rpc.Client?I found that the current ethclient interface cannot retrieve block information for a transaction when fetching its details.
go-ethereum/ethclient/ethclient.go
Line 227 in ee04332
Therefore, I want to directly call the
eth_getTransactionByHashmethod from the client.