Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/blocktest: add package for shared test code #27270

Merged
merged 6 commits into from
Jul 11, 2023
Merged

internal/blocktest: add package for shared test code #27270

merged 6 commits into from
Jul 11, 2023

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented May 15, 2023

dry

@jsvisa
internal: add blocktest to store block related test heelper
398931b 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
core: use blocktest.NewHasher, dry
7920b40 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/ethapi: use blocktest.NewHasher
7c72ba6 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
core/rawdb: simplify
35559b0 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/blocktest: add code document
7bb5401 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
Copy link
Contributor Author

jsvisa commented Jun 20, 2023

@rjl493456442 please take a look, thanks.

@jsvisa jsvisa changed the title core,internal: add module internal/blocktest core,internal: add package internal/blocktest Jun 20, 2023
holiman
holiman approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the test_hash_test.go is removed

@jsvisa jsvisa requested a review from fjl June 29, 2023 01:22
@holiman holiman added this to the 1.12.1 milestone Jul 11, 2023
@fjl fjl changed the title core,internal: add package internal/blocktest internal/blocktest: add package for shared test code Jul 11, 2023
@fjl fjl merged commit aecf3f9 into ethereum:master Jul 11, 2023
1 check passed
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@jsvisa @devopsbo3
internal/blocktest: add package for shared test code (ethereum#27270)
9a984bc
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "internal/blocktest: add package for shared test code (ethereu…
1cf6d5d 
…m#27270)"

This reverts commit 9a984bc.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "internal/blocktest: add package for shared test code (ethereu…
579bdf2 
…m#27270)"

This reverts commit 9a984bc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl fjl approved these changes

@holiman holiman holiman approved these changes

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jsvisa @fjl @holiman