beacon/types: add beacon chain data types #27292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
reviewed
May 17, 2023
beacon/merkle/merkle.go
Outdated
|
|
||
| type Values []Value | ||
|
|
||
| var ValueT = reflect.TypeOf(Value{}) |
There was a problem hiding this comment.
we can make this private, right?
karalabe
reviewed
May 17, 2023
| // Value represents either a 32 byte value or hash node in a binary merkle tree/partial proof. | ||
| type Value [32]byte | ||
|
|
||
| type Values []Value |
There was a problem hiding this comment.
You you pls add a short doc here?
karalabe
reviewed
May 17, 2023
beacon/types/header.go
Outdated
| "github.com/ethereum/go-ethereum/beacon/merkle" | ||
| "github.com/ethereum/go-ethereum/beacon/params" | ||
| "github.com/ethereum/go-ethereum/common" | ||
| "github.com/minio/sha256-simd" |
There was a problem hiding this comment.
Pls replace this with the crypto version
|
Hi, the pr includes a new yaml dependency |
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
* beacon/types: add beacon chain data types * beacon/merkle: added comments * go.mod: cleanups --------- Co-authored-by: Péter Szilágyi <peterke@gmail.com>
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 867efd5.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 867efd5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds beacon chain data types required by blsync.