Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core,console: replace noarg fmt.Errorf with errors.New #27332

Merged
merged 4 commits into from
May 25, 2023
Merged

core,console: replace noarg fmt.Errorf with errors.New #27332

merged 4 commits into from
May 25, 2023

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented May 24, 2023

similar to #27329

@jsvisa
core: replace noarg fmt.Errorf with errors.New
3d0f494 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
console: replace noarg fmt.Errorf with errors.New
d64f44f 
Signed-off-by: jsvisa <delweng@gmail.com>
@s1na
Copy link
Contributor

s1na commented May 24, 2023 

>>> build/cache/golangci-lint-1.51.1-linux-amd64/golangci-lint run --config .golangci.yml ./...
core/types/block.go:1: : # github.com/ethereum/go-ethereum/core/types [github.com/ethereum/go-ethereum/core/types.test]
core/types/log_test.go:21:2: "fmt" imported and not used
core/types/log_test.go:100:14: undefined: errors (typecheck)
// Copyright 2014 The go-ethereum Authors
core/types/hashing_test.go:30:2: could not import github.com/ethereum/go-ethereum/core/types (-: # github.com/ethereum/go-ethereum/core/types [github.com/ethereum/go-ethereum/core/types.test]
core/types/log_test.go:21:2: "fmt" imported and not used
core/types/log_test.go:100:14: undefined: errors) (typecheck)
	"github.com/ethereum/go-ethereum/core/types"
	^
util.go:48: exit status 1

@jsvisa
core: go autoimport
3db756a 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
core: dry
ff9d654 
Signed-off-by: jsvisa <delweng@gmail.com>
@holiman holiman added this to the 1.12.1 milestone May 25, 2023
@holiman holiman merged commit 6c73276 into ethereum:master May 25, 2023
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@jsvisa @devopsbo3
core,console: replace noarg fmt.Errorf with errors.New (ethereum#27332)
a8091f2 
* core: replace noarg fmt.Errorf with errors.New

Signed-off-by: jsvisa <delweng@gmail.com>

* console: replace noarg fmt.Errorf with errors.New

Signed-off-by: jsvisa <delweng@gmail.com>

* core: go autoimport

Signed-off-by: jsvisa <delweng@gmail.com>

* core: dry

Signed-off-by: jsvisa <delweng@gmail.com>

---------

Signed-off-by: jsvisa <delweng@gmail.com>
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "core,console: replace noarg fmt.Errorf with errors.New (ether…
482f17d 
…eum#27332)"

This reverts commit a8091f2.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "core,console: replace noarg fmt.Errorf with errors.New (ether…
387b276 
…eum#27332)"

This reverts commit a8091f2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@rjl493456442 rjl493456442 rjl493456442 approved these changes

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.1
Development

Successfully merging this pull request may close these issues.
4 participants
@jsvisa @s1na @holiman @rjl493456442