core/state: mark account as dirty when resetObject occurs #27339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
reviewed
Jun 1, 2023
| @@ -162,7 +163,7 @@ func (ch resetObjectChange) revert(s *StateDB) { | |||
| } | |||
|
|
|||
| func (ch resetObjectChange) dirtied() *common.Address { | |||
| return nil | |||
| return ch.account | |||
There was a problem hiding this comment.
The address field here is not needed because resetObjectChange already contains the stateObject.
There was a problem hiding this comment.
For future readers: the semantics behind dirtied() is, that it it supposed to spit out which, if any, address was made dirty by the change. And dirty means that it affects the state trie, so needs to update the stateroot.
For example, the refundChange do not mark something dirty, because it only affects the runtime but has no persistent effect on the state. Same with accessListAddAccountChange,addPreimageChange, addLogChange and transientStorageChange
fjl
approved these changes
Jun 1, 2023
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…7339) This changes the journal logic to mark the state object dirty immediately when it is reset. We're mostly adding this change to appease the fuzzer. Marking it dirty immediately makes no difference in practice because accounts will always be modified by EVM right after creation.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…hereum#27339)" This reverts commit 68dea62.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…hereum#27339)" This reverts commit 68dea62.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns the dirty marker behavior in state journal. It's OK to not mark it as dirty in resetObject, but would be nice to align the behavior with other changes.