core: 4844 opcode and precompile #27356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
reviewed
May 30, 2023
karalabe
reviewed
May 30, 2023
karalabe
reviewed
May 30, 2023
karalabe
reviewed
May 30, 2023
karalabe
reviewed
May 30, 2023
MariusVanDerWijden
force-pushed
the
4844-opcode-precompile
branch
from
54fae12
to
7fbfdf7
Compare
MariusVanDerWijden
force-pushed
the
4844-opcode-precompile
branch
from
7fbfdf7
to
3bc9603
Compare
holiman
reviewed
May 31, 2023
core/vm/contracts.go
Outdated
| common.BytesToAddress([]byte{7}): &bn256ScalarMulIstanbul{}, | ||
| common.BytesToAddress([]byte{8}): &bn256PairingIstanbul{}, | ||
| common.BytesToAddress([]byte{9}): &blake2F{}, | ||
| common.BytesToAddress([]byte{20}): &pointEvaluation{}, |
There was a problem hiding this comment.
Yep, because of the BLS precompiles
core/vm/contracts.go
Outdated
| return nil, errors.Join(errBlobVerifyKZGProof, err) | ||
| } | ||
|
|
||
| return common.CopyBytes(kzg4844.PrecompileReturnValue[:]), nil |
There was a problem hiding this comment.
Wait -- is this using a public global variable in the kzg8444 package to return the response?
Wow, that's dirtier than ..
There was a problem hiding this comment.
I mean... what if an rpc call happens to invoke the precompile too, for example?
Or the miner, building a block?
There was a problem hiding this comment.
Ahh.. wait.. the return value of this op is not input-dependent??
There was a problem hiding this comment.
Yes the precompile returns a constant
MariusVanDerWijden
changed the title
MariusVanDerWijden
changed the title
MariusVanDerWijden
force-pushed
the
4844-opcode-precompile
branch
from
c42b5d4
to
5e0918a
Compare
karalabe
reviewed
Jun 2, 2023
karalabe
reviewed
Jun 2, 2023
karalabe
reviewed
Jun 2, 2023
karalabe
reviewed
Jun 2, 2023
karalabe
reviewed
Jun 2, 2023
karalabe
reviewed
Jun 5, 2023
| @@ -1081,7 +1082,7 @@ func (b *kzgPointEvaluation) RequiredGas(input []byte) uint64 { | |||
|
|
|||
| const ( | |||
| blobVerifyInputLength = 192 // Max input length for the point evaluation precompile. | |||
| blobVerifyKZGVersion uint8 = 0x01 // Version byte for the point evaluation precompile. | |||
| blobCommitmentVersionKZG uint8 = 0x01 // Version byte for the point evaluation precompile. | |||
There was a problem hiding this comment.
This is part of the params package, shouldn't we use that?
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
* core: crypto: implement BLOBHASH and pointEval precompile * core: crypto: fixed nitpicks, moved precompile return value * core/vm: fix review comments
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 4590721.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 4590721.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the pointEvaluation precompile and the DATAHASH opcode both are needed for 4844
Spec: https://eips.ethereum.org/EIPS/eip-4844#point-evaluation-precompile