Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

les, eth: fix typo in comment #27369

Merged
merged 2 commits into from
May 30, 2023
Merged

les, eth: fix typo in comment #27369

merged 2 commits into from
May 30, 2023

Conversation

ucwong
Copy link
Contributor

@ucwong ucwong commented May 27, 2023

No description provided.

@bionics-maestro
Copy link

Hi! Who will approve your pull request? Ethereum is decentralized. Please tell me and don't ignore me. I am a beginner developer learning new things.

@bionics-maestro
Copy link

Hi! Who will approve your pull request? Ethereum is decentralized. Please tell me and don't ignore me. I am beginner developer learning new things.

@shaft3796
Copy link

Hi! Who will approve your pull request? Ethereum is decentralized. Please tell me and don't ignore me. I am beginner developer learning new things.

Hi, even if Ethereum is decentralized, the approval system for pull requests works the same than for any github repository, collaborators can approve it. However, the nodes running on Geth decides if they update their node or if they stay with an older version, this is how blockchain forks happen, some nodes update, some don't. This repository provide an official implementation of the Ethereum protocol, but every node is free to run any correct implementation of the protocol.

Hope I was clear : )

@bionics-maestro
Copy link

Hi! Who will approve your pull request? Ethereum is decentralized. Please tell me and don't ignore me. I am beginner developer learning new things.

Hi, even if Ethereum is decentralized, the approval system for pull requests works the same than for any github repository, collaborators can approve it. However, the nodes running on Geth decides if they update their node or if they stay with an older version, this is how blockchain forks happen, some nodes update, some don't. This repository provide an official implementation of the Ethereum protocol, but every node is free to run any correct implementation of the protocol.

Hope I was clear : )

Can anyone become collaborator to approve pull request in this repository?

@panicalways
Copy link
Contributor

Contact the Ethereum Foundation. @bionics-maestro

holiman
holiman requested changes May 29, 2023
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but this is a copy of eth/api.go, where these same typos are also present. Wanna fix those too while you're at it ?

@ucwong ucwong requested a review from karalabe as a code owner May 29, 2023 13:03
@ucwong
Copy link
Contributor Author

ucwong commented May 29, 2023

Thanks, but this is a copy of eth/api.go, where these same typos are also present. Wanna fix those too while you're at it ?

Done

@ucwong ucwong requested a review from holiman May 29, 2023 13:04
@ucwong ucwong changed the title les: typo les, eth/api: typo May 29, 2023
@fjl fjl changed the title les, eth/api: typo les, eth: fix typo in comment May 30, 2023
@fjl fjl merged commit 560dceb into ethereum:master May 30, 2023
@fjl fjl added this to the 1.12.1 milestone May 30, 2023
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@ucwong @devopsbo3
les, eth: fix typo in comment (ethereum#27369)
c56e60b
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "les, eth: fix typo in comment (ethereum#27369)"
92b2c56 
This reverts commit c56e60b.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "les, eth: fix typo in comment (ethereum#27369)"
6bc2353 
This reverts commit c56e60b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjl493456442 rjl493456442 rjl493456442 approved these changes

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi zsfelfoldi is a code owner

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

@holiman holiman Awaiting requested review from holiman holiman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.1
Development

Successfully merging this pull request may close these issues.
7 participants
@ucwong @bionics-maestro @shaft3796 @panicalways @holiman @rjl493456442 @fjl