core/types: ensure receipts EncodeIndex writes + support blobtx-receipts #27470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue which can happen on blob-tx-testnets, where we try to encode the receipt of a blob-transaction, but ends up writing nothing: which is "deletion" as far as the stacktrie is concerned, causing panic.
This PR does two things:
As for the second bullet, a different way of doing it would be to do what the transactions already does
Simply write
type ... rlp(data)
for typed data. That way we wouldn't have to bother with "adding support for type x", it would just work.I don't know which is best, I currently left it as is.