Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/jsre: fix typos #27500

Merged
merged 1 commit into from
Jun 19, 2023
Merged

internal/jsre: fix typos #27500

merged 1 commit into from
Jun 19, 2023

Conversation

joohhnnn
Copy link
Contributor

fix typos

@joohhnnn joohhnnn changed the title fix typos internal/jsre: fix typos Jun 17, 2023
@fjl
Copy link
Contributor

fjl commented Jun 19, 2023

We usually do not fix typos in vendored code, because the file will get overwritten the next time it is updated. However, in this case, I'll make an exception because the web3.js we use is very old and will probably never be updated...

@fjl fjl merged commit 168d0cc into ethereum:master Jun 19, 2023
@fjl fjl added this to the 1.12.1 milestone Jun 19, 2023
@joohhnnn joohhnnn deleted the web3_typos branch June 19, 2023 06:37
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants