Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/secp256k1: define NDEBUG only if not defined #27550

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

fbac
Copy link
Contributor

@fbac fbac commented Jun 23, 2023

NDEBUG can be defined in some architechtures, by checking it with ifndef we avoid compiler warning problems, such as:

Error: ../../../go/pkg/mod/github.com/ethereum/go-ethereum@v1.10.26/crypto/secp256k1/secp256.go:28:9: warning: 'NDEBUG' macro redefined [-Wmacro-redefined]

@fjl fjl changed the title crypto: define NDEBUG only if not defined crypto/secp256k1: define NDEBUG only if not defined Jun 23, 2023
@fjl fjl merged commit 942ba4d into ethereum:master Jun 23, 2023
1 check passed
@fbac fbac deleted the crypto-ifndef-ndebug branch June 23, 2023 21:22
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants