core: stop chain when tests are finished #27660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightclient
reviewed
Jul 5, 2023
There was a problem hiding this comment.
It isn't really necessary. The goroutines will be cleaned up by the runtime when the test exits I see that goroutines will sit around until all tests exit, so that could slow other tests down a bit -- journaling isn't relevant because the tests use in-memory databases (and don't reopen them).
Do you know how much faster the core/blockchain tests run with this change?
|
I ran the tests before and after the change, not a notable difference in execution time. The reason for the PR is as you note, the goroutines hang out while other tests are running and it seems better to clean-up resources in tests when not too difficult. Also most other tests call blockchain.Stop. |
lightclient
approved these changes
Jul 5, 2023
holiman
changed the title
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
core (blockchain_test): add chain.Stop() to tests
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 625e847.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 625e847.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds calls for chain.Stop() to tests that call NewBlockChain