Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p/discover: filter bootnodes by netrestrict #27701

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Jul 12, 2023

This prevents an issue where the node would attempt to contact the bootstrap nodes even if they weren't contained in the netrestrict list.

Fixes #27668

This prevents an issue where the node would attempt to contact the bootstrap
nodes even if they weren't contained in the netrestrict list.
@fjl fjl requested a review from zsfelfoldi as a code owner July 12, 2023 01:16
@fjl fjl requested a review from lightclient July 12, 2023 01:18
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fjl fjl merged commit a426999 into ethereum:master Jul 12, 2023
@fjl fjl added this to the 1.12.1 milestone Jul 12, 2023
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
This prevents an issue where the node would attempt to contact the bootstrap
nodes even if they weren't contained in the netrestrict list.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private PoA connecting to random public nodes
2 participants