Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/ethapi: implement eth_getBlockReceipts #27702

Merged
merged 15 commits into from
Aug 15, 2023
Merged

internal/ethapi: implement eth_getBlockReceipts #27702

merged 15 commits into from
Aug 15, 2023

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Jul 12, 2023

@jsvisa jsvisa marked this pull request as draft July 12, 2023 02:22
s1na
s1na reviewed Jul 12, 2023
View reviewed changes
internal/ethapi/api.go Outdated Show resolved Hide resolved
@s1na
Copy link
Contributor

s1na commented Jul 12, 2023

Also please add to internal/web3ext/web3ext.go.

@jsvisa
Copy link
Contributor Author

jsvisa commented Jul 12, 2023

We need to add test cases, this depends on #27527, so I'll mark this PR ready after #27527 is merged.

@jsvisa jsvisa marked this pull request as ready for review July 13, 2023 16:10
@jsvisa jsvisa requested a review from s1na July 13, 2023 16:10
@jsvisa
Copy link
Contributor Author

jsvisa commented Jul 22, 2023

@s1na @lightclient PTAL

@jsvisa jsvisa mentioned this pull request Jul 22, 2023
Closed
s1na
s1na reviewed Aug 1, 2023
View reviewed changes
internal/jsre/deps/web3.js Outdated Show resolved Hide resolved
@jsvisa
internal/ethapi: marshalReceipt
a84c142 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/ethapi: add GetBlockReceipts RPC
28d7347 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
ethclient: add BlockReceipts client
c658bb5 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/ethapi: dry
cb91e0e 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/web3ext: add js method
7d6c8e1 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/jsre: add inputBlockNumberOrHashFormatter
2bb8cfd 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/web3ext: format input blockNrOrHash
f9b59dd 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/jsre: export inputBlockNumberOrHashFormatter
cf7ea1e 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/ethapi: add a helper to setup receipt backend
ae56e11 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/ethapi: early quit if block is nil
ec72fb3 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/ethapi: add getBlockReceipts testcase
54dfe95 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal: return null if block not found
c0d32b8 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
Revert "internal/jsre: export inputBlockNumberOrHashFormatter"
0f4753e 
This reverts commit cf7ea1e.

Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
Revert "internal/jsre: add inputBlockNumberOrHashFormatter"
db4c6d8 
This reverts commit 2bb8cfd.

Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
Revert "internal/web3ext: format input blockNrOrHash"
7c090aa 
This reverts commit f9b59dd.

Signed-off-by: jsvisa <delweng@gmail.com>
s1na
s1na approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jul 5, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
b949234
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jul 26, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
fe04f05
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 1, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
f66c908
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 11, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
698db59
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
b167539
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
51abc85
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
10554c2
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
75c3da2
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
eafddd0
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 19, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
1461b0e
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 21, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
ef40632
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 22, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
7c2dcab
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 22, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
561ffcc
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 23, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
7d71577
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 24, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
e031734
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 25, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
cb34a18
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 25, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
16eb6da
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
084b58a
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
6d1d90e
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
1e18ae7
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 2, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
2e224e9
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
4021053
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
e7461bc
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
22aa634
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
9273f7b
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 10, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
5925fb6
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
c02308e
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
7dbc714
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
7c3cb19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@s1na s1na s1na approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jsvisa @s1na @holiman @hitdavid @fjl