les: remove obsolete code related to PoW header syncing #27737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsfelfoldi
requested review from
rjl493456442,
karalabe and
holiman
as code owners
|
Now that's an agressive PR. I like! |
Closed
meowsbits
added a commit
to etclabscore/ethereum.go-ethereum
that referenced
this pull request
Aug 31, 2023
…reum#27737)" This reverts commit d4d88f9. On branch etc-lite-patch-dev_with-reverts-from-chris Changes to be committed: modified: cmd/geth/main.go modified: cmd/utils/flags.go modified: eth/ethconfig/config.go modified: eth/ethconfig/gen_config.go modified: les/api_backend.go modified: les/api_test.go new file: les/catalyst/api.go new file: les/catalyst/api_test.go modified: les/client.go modified: les/client_handler.go new file: les/downloader/api.go new file: les/downloader/downloader.go new file: les/downloader/downloader_test.go new file: les/downloader/events.go new file: les/downloader/metrics.go new file: les/downloader/modes.go new file: les/downloader/peer.go new file: les/downloader/queue.go new file: les/downloader/queue_test.go new file: les/downloader/resultstore.go new file: les/downloader/statesync.go new file: les/downloader/testchain_test.go new file: les/downloader/types.go new file: les/fetcher.go new file: les/fetcher/block_fetcher.go new file: les/fetcher/block_fetcher_test.go new file: les/fetcher_test.go modified: les/handler_test.go modified: les/odr_test.go modified: les/peer.go new file: les/pruner.go new file: les/pruner_test.go modified: les/request_test.go modified: les/retrieve.go new file: les/sync.go new file: les/sync_test.go modified: les/test_helper.go new file: les/ulc.go new file: les/ulc_test.go Changes not staged for commit: modified: tests/testdata (new commits)
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This change removes PoW header syncing related code from LES and also deletes duplicated packages les/catalyst, les/downloader and les/fetcher. These package copies were created because people wanted to make changes in their eth/ counterparts, but weren't able to adapt LES code to the API changes.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…reum#27737)" This reverts commit d84ccdb.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…reum#27737)" This reverts commit d84ccdb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes PoW header syncing related code from
lesand also deletes duplicated packagescatalyst,downloaderandfetcher.