core, trie: track state change set with account address #27815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
reviewed
Jul 31, 2023
| accountsOrigin map[common.Hash][]byte // The original value of mutated accounts in 'slim RLP' encoding | ||
| storagesOrigin map[common.Hash]map[common.Hash][]byte // The original value of mutated slots in prefix-zero trimmed rlp format | ||
| accounts map[common.Hash][]byte // The mutated accounts in 'slim RLP' encoding | ||
| storages map[common.Hash]map[common.Hash][]byte // The mutated slots in prefix-zero trimmed rlp format |
There was a problem hiding this comment.
Shouldn't accounts and storages also be changed in the same vein?
There was a problem hiding this comment.
Accounts and storages are used by snapshot. Unfortunately, in snapshot, everything is identified by hash.
technically, it's possible to covert from map[common.Address][]byte to map[common.Hash][]byte inside of snapshot. But i feel it's unworthwhile.
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…reum#27815)" This reverts commit 426aec5.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…reum#27815)" This reverts commit 426aec5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tracks state change set with account address instead of addrHash.
The benefits of this changes are:
Although it will cause inconsistency, because storage slots are still identified by
slothash. The reason of using hash for slot is: when the entire storage is nuked,
slots has to be iterated from trie, and only slot hash is available there(it's a pain).