Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: make tests pass on windows/386 #27821

Merged
merged 3 commits into from
Aug 1, 2023
Merged

tests: make tests pass on windows/386 #27821

merged 3 commits into from
Aug 1, 2023

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Jul 31, 2023

Our windows 386 builds are timing out on appveyor, on the individual test exceeding 10 minutes

panic: test timed out after 10m0s
running tests:
    TestState (10m0s)
    TestState/stLogTests/log4_MaxTopic.json (0s)
    TestState/stLogTests/log4_MaxTopic.json/London/0/trie (0s)
    TestState/stMemoryTest/buffer.json (14s)
    TestState/stMemoryTest/buffer.json/Merge/334/snap (0s)

This PR splits up the tests execution, might make it work again.

@holiman
Copy link
Contributor Author

holiman commented Jul 31, 2023

Nope. no go

ok  	github.com/ethereum/go-ethereum/signer/storage	0.128s
panic: test timed out after 10m0s
running tests:
	TestStateCurrent (10m0s)
	TestStateCurrent/stPreCompiledContracts2/CallRipemd160_4.json (0s)
	TestStateCurrent/stPreCompiledContracts2/CallRipemd160_4.json/Merge/0/snap (0s)
	TestStateCurrent/stPreCompiledContracts2/ecrecoverWeirdV.json (4s)
	TestStateCurrent/stPreCompiledContracts2/ecrecoverWeirdV.json/ConstantinopleFix/27/snap (0s)
goroutine 288213 [running]:

@holiman holiman changed the title tests: split up state test execution tests: make tests pass on windows/386 Jul 31, 2023
@holiman
Copy link
Contributor Author

holiman commented Jul 31, 2023

This PR now instead bumps the timeout in ci.go to 20 minutes.

@karalabe karalabe added this to the 1.12.1 milestone Aug 1, 2023
@karalabe karalabe merged commit 852be57 into ethereum:master Aug 1, 2023
1 check passed
@holiman holiman deleted the parallel_tests branch August 1, 2023 08:03
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@holiman @devopsbo3
tests: make tests pass on windows/386 (ethereum#27821)
76964e4 
* tests: split up state test execution

* Revert "tests: split up state test execution"

This reverts commit 96017c2.

* build: bump test timeout to 20 minutes
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "tests: make tests pass on windows/386 (ethereum#27821)"
9a001fc 
This reverts commit 76964e4.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "tests: make tests pass on windows/386 (ethereum#27821)"
195b26f 
This reverts commit 76964e4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjl493456442 rjl493456442 rjl493456442 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.1
Development

Successfully merging this pull request may close these issues.
3 participants
@holiman @rjl493456442 @karalabe