Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: replace data gas to blob gas in comments #27825

Merged
merged 4 commits into from
Aug 1, 2023
Merged

all: replace data gas to blob gas in comments #27825

merged 4 commits into from
Aug 1, 2023

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Aug 1, 2023

No description provided.

karalabe
karalabe approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@karalabe karalabe added this to the 1.12.1 milestone Aug 1, 2023
@karalabe karalabe merged commit 3ca92f7 into ethereum:master Aug 1, 2023
1 check passed
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@jsvisa @devopsbo3
all: replace data gas to blob gas in comments (ethereum#27825)
857b4f4 
* eth: excessDataGas -> excessBlobGas

* consensus: data gas -> blob gas

* core: data gas -> blob gas

* params: data gas -> blob gas
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "all: replace data gas to blob gas in comments (ethereum#27825)"
6c66c07 
This reverts commit 857b4f4.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "all: replace data gas to blob gas in comments (ethereum#27825)"
25d0633 
This reverts commit 857b4f4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

@gballet gballet Awaiting requested review from gballet gballet is a code owner

@holiman holiman Awaiting requested review from holiman holiman is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jsvisa @karalabe