Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/rawdb, ethdb/pebble: avoid fsync db in tests #27836

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Aug 2, 2023

Proof of concept alternative to #27768 .
I don't have a mac, so can't check if it works or not.

@jsvisa
Copy link
Contributor

jsvisa commented Aug 2, 2023

let me have a test :)

@jsvisa
Copy link
Contributor

jsvisa commented Aug 2, 2023

the testing latency reduced from 47s to 20s in may mac air m1, and the flamegraph is similar to leveldb's(without the time-window of vfs)

image

@karalabe
Copy link
Member

karalabe commented Aug 2, 2023

Master:

% go test -v ./core --run=TestShortRepairWithSnapshots
=== RUN   TestShortRepairWithSnapshots
--- PASS: TestShortRepairWithSnapshots (0.35s)

PR:

% go test -v ./core --run=TestShortRepairWithSnapshots
=== RUN   TestShortRepairWithSnapshots
--- PASS: TestShortRepairWithSnapshots (0.16s)

I.e. Better, but there still seems to be some perf hit somewhere

@rjl493456442
Copy link
Member

I think we should just implement the missing feature in pebble.

@holiman
Copy link
Contributor Author

holiman commented Aug 3, 2023

the missing feature in pebble.

Which feature are you talking about? I think the sync/fsync method that they use is highly intentional

@fjl fjl merged commit f0f8703 into ethereum:master Aug 23, 2023
1 check passed
@fjl fjl added this to the 1.13.0 milestone Aug 23, 2023
@holiman holiman deleted the nosync_pebble_tests branch October 11, 2023 07:27
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Adds an option to disable fsync for database operations.
This is to make tests faster.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants