Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/types: support for optional blob sidecar in BlobTx #27841

Merged
merged 22 commits into from
Aug 14, 2023
Merged

core/types: support for optional blob sidecar in BlobTx #27841

merged 22 commits into from
Aug 14, 2023

Commits on Aug 7, 2023

  1. core/types: remove blob methods from TxData interface 

    Only blob transactions can have blobs, so there is no need to have
these methods on every single tx type.
    @fjl
    fjl committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    16dc741 View commit details
    Browse the repository at this point in the history

  2. core/types: optional blob sidecar in BlobTx

    @fjl
    fjl committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    13b7f12 View commit details
    Browse the repository at this point in the history

  3. core: verify absence of sidecar when importing blocks

    @fjl
    fjl committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    d2c86cd View commit details
    Browse the repository at this point in the history

  4. core/txpool: new blob tx type integration

    @fjl
    fjl committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    10b14f4 View commit details
    Browse the repository at this point in the history

  5. core: fix comment

    @fjl
    fjl committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    bd582b5 View commit details
    Browse the repository at this point in the history

  6. core/types: remove some receiver names in TxData

    @fjl
    fjl committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    014d70a View commit details
    Browse the repository at this point in the history

  7. all: removing txpool.Transaction

    @fjl
    fjl committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    394ef8b View commit details
    Browse the repository at this point in the history

  8. miner: strip sidecar in commit

    @fjl
    fjl committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    f756841 View commit details
    Browse the repository at this point in the history

  9. eth: fix issue in test

    @fjl
    fjl committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    d6945e9 View commit details
    Browse the repository at this point in the history

  10. core/txpool/blobpool: check sidecar is still there after decoding tx

    @fjl
    fjl committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    a03f3d1 View commit details
    Browse the repository at this point in the history

  11. core/types: remove unused method blobGasFeeCap

    @fjl
    fjl committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    b84a6ed View commit details
    Browse the repository at this point in the history

  12. core/txpool/blobpool: add error message

    @fjl
    fjl committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    e9dab44 View commit details
    Browse the repository at this point in the history

  13. core: improve validation loop in InsertReceiptChain 

    Seems better to have a variable for the iteration item.
    @fjl
    fjl committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    67fec27 View commit details
    Browse the repository at this point in the history

  14. core: check absence of blob sidecar in InsertReceiptChain

    @fjl
    fjl committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    1de750f View commit details
    Browse the repository at this point in the history

  15. core/txpool/blobpool: simplify some code in limbo 

    No need to keep track of the txhash in a variable when we are storing
the full tx.
    @fjl
    fjl committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    f37d471 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. eth/downloader: add check for blob absence in DeliverBodies

    @fjl
    fjl committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    9363dd5 View commit details
    Browse the repository at this point in the history

  2. core/types: rename BlobSidecar to BlobTxSidecar

    @fjl
    fjl committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    d2f7c47 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. core/types: add a method to compute blob hashes from BlobTxSidecar

    @fjl
    fjl committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    1995292 View commit details
    Browse the repository at this point in the history

  2. core/types: fix crash in copy for BlobTx

    @fjl
    fjl committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    3edddbc View commit details
    Browse the repository at this point in the history

  3. core/types: add a test to verify hashing of BlobTx ignores the sidecar

    @fjl
    fjl committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    b6e34aa View commit details
    Browse the repository at this point in the history

  4. core/types: make Size work correctly for BlobTx with sidecar 

    Also fixes a pretty serious bug where the WithoutBlobSidecar method didn't
actually remove the sidecar...
    @fjl
    fjl committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    e86e43e View commit details
    Browse the repository at this point in the history

  5. core: remove redundant tx type check in block validator

    @fjl
    fjl committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    de44d26 View commit details
    Browse the repository at this point in the history