eth/catalyst: set finalized block hash properly in dev mode #27886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remove the change to the tests submodule! |
|
but it's dev mode anyway, right? does it really matter the finalization block is at the epoch boundary or not? |
Honestly it probably doesn't really matter that much. But it makes dev-mode behavior somewhat more in-line with a real network. |
eth/catalyst/simulated_beacon.go
Outdated
| @@ -157,14 +157,21 @@ func (c *SimulatedBeacon) sealBlock(withdrawals []*types.Withdrawal) error { | |||
| } | |||
| payload := envelope.ExecutionPayload | |||
|
|
|||
| var finalizedHash common.Hash | |||
| if payload.Number%32 == 0 { | |||
There was a problem hiding this comment.
perhaps define a constant for it? e.g. devEpochLength or whatever.
holiman
reviewed
Aug 17, 2023
Co-authored-by: Martin Holst Swende <martin@swende.se>
MariusVanDerWijden
approved these changes
Aug 21, 2023
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…#27886) Co-authored-by: Martin Holst Swende <martin@swende.se>
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…thereum#27886)" This reverts commit 9070fc8.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…thereum#27886)" This reverts commit 9070fc8.
sduchesneau
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Jan 4, 2024
sduchesneau
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Feb 26, 2024
Conflicts: eth/catalyst/simulated_beacon.go The PR changes simulated beacon. Took upstream version as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dev mode, the finalized block should be the block that was produced at the start of the current epoch (block number 0, 32, 64, ...)