Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: use winio for named pipes #27972

Merged
merged 2 commits into from
Aug 23, 2023
Merged

rpc: use winio for named pipes #27972

merged 2 commits into from
Aug 23, 2023

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Aug 22, 2023

This PR replaces the old npipe implementation with official microsoft-code: https://github.com/microsoft/go-winio/

Copy link
Contributor

@fjl fjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, let's see if tests will work.

@fjl fjl merged commit 16946d2 into ethereum:master Aug 23, 2023
2 checks passed
@fjl fjl added this to the 1.13.0 milestone Aug 23, 2023
@holiman holiman deleted the winio branch October 11, 2023 07:25
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
We're trying a new named pipe library, which should hopefully fix some occasional failures in CI.

---------

Co-authored-by: Felix Lange <fjl@twurst.com>
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants